Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::should_implement_trait: Checks for methods that should live in a trait implementation of a std trait (see llogiq’s blog post for further information) instead of an inherent implementation
What it meansChecks for methods that should live in a trait implementation of a std trait (see llogiq’s blog post for further information) instead of an inherent implementation. It is in the style group and warns by default.
Does it matter?
Implementing the traits improve ergonomics for users of the code, often with very little cost. Also people seeing a mul(...) method may expect * to work equally, so you should have good reason to disappoint them.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
struct X;
impl X {
fn add(&self, other: &X) -> X {
// ..
}
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::should_implement_trait)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
should_implement_trait = "allow"One run
cargo clippy -- -A clippy::should-implement-traitThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for methods that should live in a trait
implementation of a std trait (see llogiq’s blog
post for further
information) instead of an inherent implementation.
Why is this bad?
Implementing the traits improve ergonomics for users of
the code, often with very little cost. Also people seeing a mul(...)
method
may expect * to work equally, so you should have good reason to disappoint
them.
Example
struct X;
impl X {
fn add(&self, other: &X) -> X {
// ..
}
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- result_unit_errthis returns a `Result<_, ()>`
- same_item_pushit looks like the same item is being pushed into this `Vec`
- self_named_constructorsconstructor `foo` has the same name as the type
- single_char_add_strWarns when using push_str/insert_str with a single-character string literal where push/insert with a char would work fine
- single_component_path_importsthis import is redundant
- single_matchChecks for matches with a single arm where an if let will usually suffice. This intentionally does not lint if there are comments inside of the other arm, so as to allow the user to document why having another explicit pattern with an empty body is necessary, or because the comments need to be preserved for other reasons
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?