Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::skip_while_next: Checks for usage of _.skip_while(condition).next()
What it meansChecks for usage of _.skip_while(condition).next(). It is in the complexity group and warns by default.
Does it matter?
Readability, this can be written more concisely as _.find(!condition).
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
vec.iter().skip_while(|x| **x == 0).next();
Write this instead
vec.iter().find(|x| **x != 0);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::skip_while_next)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
skip_while_next = "allow"One run
cargo clippy -- -A clippy::skip-while-nextThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of _.skip_while(condition).next().
Why is this bad?
Readability, this can be written more concisely as
_.find(!condition).
Example
vec.iter().skip_while(|x| **x == 0).next();
Use instead:
vec.iter().find(|x| **x != 0);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- seek_to_start_instead_of_rewindChecks for jumps to the start of a stream that implements Seek and uses the seek method providing Start as parameter
- short_circuit_statementChecks for the use of short circuit boolean conditions as a statement
- single_element_loopfor loop over a single element
- some_filteruse of `Some(x).filter(|_| predicate)`
- string_from_utf8_as_bytescalling a slice of `as_bytes()` with `from_utf8` should be not necessary
- strlen_on_c_stringsChecks for usage of libc::strlen on a CString or CStr value, and suggest calling count_bytes() instead
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?