Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::short_circuit_statement: Checks for the use of short circuit boolean conditions as a statement
What it meansChecks for the use of short circuit boolean conditions as a statement. It is in the complexity group and warns by default.
Does it matter?
Using a short circuit boolean condition as a statement may hide the fact that the second part is executed or not depending on the outcome of the first part.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
f() && g(); // We should write `if f() { g(); }`.
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::short_circuit_statement)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
short_circuit_statement = "allow"One run
cargo clippy -- -A clippy::short-circuit-statementThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for the use of short circuit boolean conditions as a statement.
Why is this bad?
Using a short circuit boolean condition as a statement may hide the fact that the second part is executed or not depending on the outcome of the first part.
Example
f() && g(); // We should write `if f() { g(); }`.
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- result_map_unit_fnChecks for usage of result.map(f) where f is a function or closure that returns the unit type ()
- seek_from_currentusing `SeekFrom::Current` to start from current position
- seek_to_start_instead_of_rewindChecks for jumps to the start of a stream that implements Seek and uses the seek method providing Start as parameter
- single_element_loopfor loop over a single element
- skip_while_nextChecks for usage of _.skip_while(condition).next()
- some_filteruse of `Some(x).filter(|_| predicate)`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?