Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::string_extend_chars: calling `.extend(_.chars())`
What it meansChecks for the use of .extend(s.chars()) where s is a &str or String. It is in the style group and warns by default.
What you see
warning: calling `.extend(_.chars())` --> main.rs:6:1 | 6 | s.extend(abc.chars()); | ^^^^^^^^^^^^^^^^^^^^^ help: try: `s.push_str(abc)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#string_extend_chars = note: `#[warn(clippy::string_extend_chars)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
.push_str(s) is clearer
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let abc = "abc";
let def = String::from("def");
let mut s = String::new();
s.extend(abc.chars());
s.extend(def.chars());
Write this instead
let abc = "abc";
let def = String::from("def");
let mut s = String::new();
s.push_str(abc);
s.push_str(&def);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::string_extend_chars)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
string_extend_chars = "allow"One run
cargo clippy -- -A clippy::string-extend-charsThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for the use of .extend(s.chars()) where s is a
&str or String.
Why is this bad?
.push_str(s) is clearer
Example
let abc = "abc";
let def = String::from("def");
let mut s = String::new();
s.extend(abc.chars());
s.extend(def.chars());
The correct use would be:
let abc = "abc";
let def = String::from("def");
let mut s = String::new();
s.push_str(abc);
s.push_str(&def);
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- single_char_add_strWarns when using push_str/insert_str with a single-character string literal where push/insert with a char would work fine
- single_component_path_importsthis import is redundant
- single_matchChecks for matches with a single arm where an if let will usually suffice. This intentionally does not lint if there are comments inside of the other arm, so as to allow the user to document why having another explicit pattern with an empty body is necessary, or because the comments need to be preserved for other reasons
- tabs_in_doc_commentsusing tabs in doc comments is not recommended
- to_digit_is_someChecks for .to_digit(..).is_some() on chars
- to_string_trait_impldirect implementation of `ToString`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?