Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::unnecessary_find_map: this `.find_map(..)` can be written more simply using `.find(..)`
What it meansChecks for find_map calls that could be replaced by find or map. More specifically it checks if the closure provided is only performing one of the find or map operations and suggests the appropriate option. It is in the complexity group and warns by default.
What you see
warning: this `.find_map(..)` can be written more simply using `.find(..)` --> main.rs:3:16 | 3 | let _ = (0..3).find_map(|x| if x > 2 { Some(x) } else { None }); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#unnecessary_find_map = note: `#[warn(clippy::unnecessary_find_map)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Complexity. The intent is also clearer if only a single operation is being performed.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy does not fix this one automatically. Change the code by hand:
Flagged
let _ = (0..3).find_map(|x| if x > 2 { Some(x) } else { None });
// As there is no transformation of the argument this could be written as:
let _ = (0..3).find(|&x| x > 2);
Write this instead
let _ = (0..4).find_map(|x| Some(x + 1));
// As there is no conditional check on the argument this could be written as:
let _ = (0..4).map(|x| x + 1).next();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::unnecessary_find_map)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
unnecessary_find_map = "allow"One run
cargo clippy -- -A clippy::unnecessary-find-mapThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for find_map calls that could be replaced by find or map. More
specifically it checks if the closure provided is only performing one of the
find or map operations and suggests the appropriate option.
Why is this bad?
Complexity. The intent is also clearer if only a single operation is being performed.
Example
let _ = (0..3).find_map(|x| if x > 2 { Some(x) } else { None });
// As there is no transformation of the argument this could be written as:
let _ = (0..3).find(|&x| x > 2);
let _ = (0..4).find_map(|x| Some(x + 1));
// As there is no conditional check on the argument this could be written as:
let _ = (0..4).map(|x| x + 1).next();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- unit_argChecks for passing a unit value as an argument to a function without using a unit literal (())
- unnecessary_castcasting integer literal to `i32` is unnecessary
- unnecessary_filter_mapthis `.filter_map(..)` can be written more simply using `.filter(..)`
- unnecessary_first_then_checkunnecessary use of `first().is_none()` to check if slice is empty
- unnecessary_get_then_checkChecks the usage of .get().is_some() or .get().is_none() on std map types
- unnecessary_literal_unwrapused `unwrap()` on `Some` value
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?