Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::unnecessary_literal_unwrap: used `unwrap()` on `Some` value
What it meansChecks for .unwrap() related calls on Results and Options that are constructed. It is in the complexity group and warns by default.
What you see
warning: used `unwrap()` on `Some` value --> main.rs:3:12 | 3 | let val1 = Some(1).unwrap(); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#unnecessary_literal_unwrap = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default help: remove the `Some` and `unwrap()` | 3 - let val1 = Some(1).unwrap(); 3 + let val1 = 1; |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
It is better to write the value directly without the indirection.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let val1 = Some(1).unwrap();
let val2 = Ok::<_, ()>(1).unwrap();
let val3 = Err::<(), _>(1).unwrap_err();
Write this instead
let val1 = 1;
let val2 = 1;
let val3 = 1;
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::unnecessary_literal_unwrap)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
unnecessary_literal_unwrap = "allow"One run
cargo clippy -- -A clippy::unnecessary-literal-unwrapThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for .unwrap() related calls on Results and Options that are constructed.
Why is this bad?
It is better to write the value directly without the indirection.
Examples
let val1 = Some(1).unwrap();
let val2 = Ok::<_, ()>(1).unwrap();
let val3 = Err::<(), _>(1).unwrap_err();
Use instead:
let val1 = 1;
let val2 = 1;
let val3 = 1;
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- unnecessary_find_mapthis `.find_map(..)` can be written more simply using `.find(..)`
- unnecessary_first_then_checkunnecessary use of `first().is_none()` to check if slice is empty
- unnecessary_get_then_checkChecks the usage of .get().is_some() or .get().is_none() on std map types
- unnecessary_map_on_constructorSuggests removing the use of a map() (or map_err()) method when an Option or Result is being constructed
- unnecessary_min_or_max`0` is never greater than `7_u32` and has therefore no effect
- unnecessary_operationChecks for expression statements that can be reduced to a sub-expression
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?