Clippy lint · Complexity · checked with Clippy 0.1.99

clippy::unnecessary_min_or_max: `0` is never greater than `7_u32` and has therefore no effect

What it meansChecks for unnecessary calls to min() or max() in the following cases Either both side is constant One side is clearly larger than the other, like i32::MIN and an i32 variable It is in the complexity group and warns by default.

What you see

warning: `0` is never greater than `7_u32` and has therefore no effect
 --> main.rs:3:9
  |
3 | let _ = 0.min(7_u32);
  |         ^^^^^^^^^^^^ help: try: `0`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#unnecessary_min_or_max
  = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

In the aforementioned cases it is not necessary to call min() or max() to compare values, it may even cause confusion.

Code that does something simple in a complicated way. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

let _ = 0.min(7_u32);

Write this instead

let _ = 0;

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::unnecessary_min_or_max)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
unnecessary_min_or_max = "allow"

One run

cargo clippy -- -A clippy::unnecessary-min-or-max

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Complexitygroup

warndefault level

yesfixed by cargo clippy --fix

1.81.0added in Rust

Clippy's own documentation

What it does

Checks for unnecessary calls to min() or max() in the following cases

Either both side is constant
One side is clearly larger than the other, like i32::MIN and an i32 variable

Why is this bad?

In the aforementioned cases it is not necessary to call min() or max() to compare values, it may even cause confusion.

Example

let _ = 0.min(7_u32);

Use instead:

let _ = 0;

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Up next

Also worth your time

Did this answer your question?