Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::identity_op: Checks for identity operations, e.g., x + 0
What it meansChecks for identity operations, e.g., x + 0. It is in the complexity group and warns by default.
Does it matter?
This code can be removed without changing the meaning. So it just obscures what’s going on. Delete it mercilessly.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
x / 1 + 0 * 1 - 0 | 0;
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::identity_op)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
identity_op = "allow"One run
cargo clippy -- -A clippy::identity-opThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for identity operations, e.g., x + 0.
Why is this bad?
This code can be removed without changing the meaning. So it just obscures what’s going on. Delete it mercilessly.
Example
x / 1 + 0 * 1 - 0 | 0;
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- filter_nextChecks for usage of _.filter(_).next()
- flat_map_identityChecks for usage of flat_map(|x| x)
- get_last_with_lenaccessing last element with `x.get(x.len() - 1)`
- implied_bounds_in_implsLooks for bounds in impl Trait in return position that are implied by other bounds. This can happen when a trait is specified that another trait already has as a supertrait (e.g
- inspect_for_eachcalled `inspect(..).for_each(..)` on an `Iterator`
- int_plus_oneunnecessary `>= y + 1` or `x - 1 >=`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?