Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::int_plus_one: unnecessary `>= y + 1` or `x - 1 >=`
What it meansChecks for usage of x >= y + 1 or x - 1 >= y (and <=) in a block It is in the complexity group and warns by default.
What you see
warning: unnecessary `>= y + 1` or `x - 1 >=` --> main.rs:3:4 | 3 | if x >= y + 1 {} | ^^^^^^^^^^ help: change it to: `x > y` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#int_plus_one = note: `#[warn(clippy::int_plus_one)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Readability - better to use > y instead of >= y + 1.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
if x >= y + 1 {}
Write this instead
if x > y {}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::int_plus_one)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
int_plus_one = "allow"One run
cargo clippy -- -A clippy::int-plus-oneThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of x >= y + 1 or x - 1 >= y (and <=) in a block
Why is this bad?
Readability - better to use > y instead of >= y + 1.
Example
if x >= y + 1 {}
Use instead:
if x > y {}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- identity_opChecks for identity operations, e.g., x + 0
- implied_bounds_in_implsLooks for bounds in impl Trait in return position that are implied by other bounds. This can happen when a trait is specified that another trait already has as a supertrait (e.g
- inspect_for_eachcalled `inspect(..).for_each(..)` on an `Iterator`
- iter_countcalled `.iter().count()` on a `Vec`
- iter_kv_mapChecks for iterating a map (HashMap or BTreeMap) and ignoring either the keys or values
- let_with_type_underscorevariable declared with type underscore
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?