Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::implied_bounds_in_impls: Looks for bounds in impl Trait in return position that are implied by other bounds. This can happen when a trait is specified that another trait already has as a supertrait (e.g
What it meansLooks for bounds in impl Trait in return position that are implied by other bounds. This can happen when a trait is specified that another trait already has as a supertrait (e.g. fn() -> impl Deref + DerefMut<Target = i32> has an unnecessary Deref bound, because Deref is a supertrait of DerefMut) It is in the complexity group and warns by default.
Does it matter?
Specifying more bounds than necessary adds needless complexity for the reader.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
fn f() -> impl Deref<Target = i32> + DerefMut<Target = i32> {
// ^^^^^^^^^^^^^^^^^^^ unnecessary bound, already implied by the `DerefMut` trait bound
Box::new(123)
}
Write this instead
fn f() -> impl DerefMut<Target = i32> {
Box::new(123)
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::implied_bounds_in_impls)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
implied_bounds_in_impls = "allow"One run
cargo clippy -- -A clippy::implied-bounds-in-implsThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Looks for bounds in impl Trait in return position that are implied by other bounds.
This can happen when a trait is specified that another trait already has as a supertrait
(e.g. fn() -> impl Deref + DerefMut<Target = i32> has an unnecessary Deref bound,
because Deref is a supertrait of DerefMut)
Why is this bad?
Specifying more bounds than necessary adds needless complexity for the reader.
Limitations
This lint does not check for implied bounds transitively. Meaning that
it doesn’t check for implied bounds from supertraits of supertraits
(e.g. trait A {} trait B: A {} trait C: B {}, then having an fn() -> impl A + C)
Example
fn f() -> impl Deref<Target = i32> + DerefMut<Target = i32> {
// ^^^^^^^^^^^^^^^^^^^ unnecessary bound, already implied by the `DerefMut` trait bound
Box::new(123)
}
Use instead:
fn f() -> impl DerefMut<Target = i32> {
Box::new(123)
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- flat_map_identityChecks for usage of flat_map(|x| x)
- get_last_with_lenaccessing last element with `x.get(x.len() - 1)`
- identity_opChecks for identity operations, e.g., x + 0
- inspect_for_eachcalled `inspect(..).for_each(..)` on an `Iterator`
- int_plus_oneunnecessary `>= y + 1` or `x - 1 >=`
- iter_countcalled `.iter().count()` on a `Vec`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?