Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::into_iter_on_ref: Checks for into_iter calls on references which should be replaced by iter or iter_mut
What it meansChecks for into_iter calls on references which should be replaced by iter or iter_mut. It is in the style group and warns by default.
Does it matter?
Readability. Calling into_iter on a reference will not move out its content into the resulting iterator, which is confusing. It is better just call iter or iter_mut directly.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
(&vec).into_iter();
Write this instead
(&vec).iter();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::into_iter_on_ref)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
into_iter_on_ref = "allow"One run
cargo clippy -- -A clippy::into-iter-on-refThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for into_iter calls on references which should be replaced by iter
or iter_mut.
Why is this bad?
Readability. Calling into_iter on a reference will not move out its
content into the resulting iterator, which is confusing. It is better just call iter or
iter_mut directly.
Example
(&vec).into_iter();
Use instead:
(&vec).iter();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- infallible_destructuring_matchyou seem to be trying to use `match` to destructure a single infallible pattern
- inherent_to_stringimplementation of inherent method `to_string(&self) -> String` for type `main::A`
- init_numbered_fieldsused a field initializer for a tuple struct
- io_other_errorthis can be `std::io::Error::other(_)`
- is_digit_ascii_radixuse of `char::is_digit` with literal radix of 10
- items_after_test_moduleTriggers if an item is declared after the testing module marked with #[cfg(test)]
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?