Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::items_after_test_module: Triggers if an item is declared after the testing module marked with #[cfg(test)]
What it meansTriggers if an item is declared after the testing module marked with #[cfg(test)]. It is in the style group and warns by default.
Does it matter?
Having items declared after the testing module is confusing and may lead to bad test coverage.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
#[cfg(test)]
mod tests {
// [...]
}
fn my_function() {
// [...]
}
Write this instead
fn my_function() {
// [...]
}
#[cfg(test)]
mod tests {
// [...]
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::items_after_test_module)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
items_after_test_module = "allow"One run
cargo clippy -- -A clippy::items-after-test-moduleThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Triggers if an item is declared after the testing module marked with #[cfg(test)].
Why is this bad?
Having items declared after the testing module is confusing and may lead to bad test coverage.
Example
#[cfg(test)]
mod tests {
// [...]
}
fn my_function() {
// [...]
}
Use instead:
fn my_function() {
// [...]
}
#[cfg(test)]
mod tests {
// [...]
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- into_iter_on_refChecks for into_iter calls on references which should be replaced by iter or iter_mut
- io_other_errorthis can be `std::io::Error::other(_)`
- is_digit_ascii_radixuse of `char::is_digit` with literal radix of 10
- iter_cloned_collectcalled `.iter().cloned().collect()` on a slice to create a `Vec`
- iter_next_sliceChecks for usage of iter().next() or iter_mut().next() on a Slice or an Array
- iter_nthcalled `.iter().nth()` on a `Vec`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?