Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::io_other_error: this can be `std::io::Error::other(_)`
What it meansClippy lint io_other_error. It is in the style group and warns by default.
What you see
warning: this can be `std::io::Error::other(_)` --> main.rs:4:9 | 4 | let _ = io::Error::new(io::ErrorKind::Other, "bad".to_string()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#io_other_error = note: `#[warn(clippy::io_other_error)]` on by default help: use `std::io::Error::other` | 4 - let _ = io::Error::new(io::ErrorKind::Other, "bad".to_string()); 4 + let _ = io::Error::other("bad".to_string()); |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Since Rust 1.74, there’s the io::Error::other(_) shortcut.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
use std::io;
let _ = io::Error::new(io::ErrorKind::Other, "bad".to_string());
Write this instead
let _ = std::io::Error::other("bad".to_string());
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::io_other_error)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
io_other_error = "allow"One run
cargo clippy -- -A clippy::io-other-errorThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
This lint warns on calling io::Error::new(..) with a kind of
io::ErrorKind::Other.
Why is this bad?
Since Rust 1.74, there’s the io::Error::other(_) shortcut.
Example
use std::io;
let _ = io::Error::new(io::ErrorKind::Other, "bad".to_string());
Use instead:
let _ = std::io::Error::other("bad".to_string());
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- inherent_to_stringimplementation of inherent method `to_string(&self) -> String` for type `main::A`
- init_numbered_fieldsused a field initializer for a tuple struct
- into_iter_on_refChecks for into_iter calls on references which should be replaced by iter or iter_mut
- is_digit_ascii_radixuse of `char::is_digit` with literal radix of 10
- items_after_test_moduleTriggers if an item is declared after the testing module marked with #[cfg(test)]
- iter_cloned_collectcalled `.iter().cloned().collect()` on a slice to create a `Vec`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?