Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::iter_count: called `.iter().count()` on a `Vec`
What it meansChecks for the use of .iter().count(). It is in the complexity group and warns by default.
What you see
warning: called `.iter().count()` on a `Vec` --> main.rs:5:1 | 5 | some_vec.iter().count(); | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `some_vec.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#iter_count = note: `#[warn(clippy::iter_count)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
.len() is more efficient and more readable.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let some_vec = vec![0, 1, 2, 3];
some_vec.iter().count();
&some_vec[..].iter().count();
Write this instead
let some_vec = vec![0, 1, 2, 3];
some_vec.len();
&some_vec[..].len();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::iter_count)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
iter_count = "allow"One run
cargo clippy -- -A clippy::iter-countThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for the use of .iter().count().
Why is this bad?
.len() is more efficient and more
readable.
Example
let some_vec = vec![0, 1, 2, 3];
some_vec.iter().count();
&some_vec[..].iter().count();
Use instead:
let some_vec = vec![0, 1, 2, 3];
some_vec.len();
&some_vec[..].len();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- implied_bounds_in_implsLooks for bounds in impl Trait in return position that are implied by other bounds. This can happen when a trait is specified that another trait already has as a supertrait (e.g
- inspect_for_eachcalled `inspect(..).for_each(..)` on an `Iterator`
- int_plus_oneunnecessary `>= y + 1` or `x - 1 >=`
- iter_kv_mapChecks for iterating a map (HashMap or BTreeMap) and ignoring either the keys or values
- let_with_type_underscorevariable declared with type underscore
- manual_abs_diffDetects patterns like if a > b { a - b } else { b - a } and suggests using a.abs_diff(b)
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?