Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::mem_replace_option_with_none: replacing an `Option` with `None`
What it meansChecks for mem::replace() on an Option with None. It is in the style group and warns by default.
What you see
warning: replacing an `Option` with `None` --> main.rs:6:16 | 6 | let replaced = mem::replace(&mut an_option, None); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `Option::take()` instead: `an_option.take()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#mem_replace_option_with_none = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Option already has the method take() for taking its current value (Some(..) or None) and replacing it with None.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
use std::mem;
let mut an_option = Some(0);
let replaced = mem::replace(&mut an_option, None);
Write this instead
let mut an_option = Some(0);
let taken = an_option.take();
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::mem_replace_option_with_none)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
mem_replace_option_with_none = "allow"One run
cargo clippy -- -A clippy::mem-replace-option-with-noneThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for mem::replace() on an Option with
None.
Why is this bad?
Option already has the method take() for
taking its current value (Some(..) or None) and replacing it with
None.
Example
use std::mem;
let mut an_option = Some(0);
let replaced = mem::replace(&mut an_option, None);
Is better expressed with:
let mut an_option = Some(0);
let taken = an_option.take();
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- match_overlapping_armsome ranges overlap
- match_ref_patsChecks for matches where all arms match a reference, suggesting to remove the reference and deref the matched expression instead
- match_result_okChecks for unnecessary ok() in while let
- mem_replace_option_with_somereplacing an `Option` with `Some(..)`
- mem_replace_with_defaultreplacing a value of type `T` with `T::default()`
- missing_enforced_import_renamesChecks for imports that do not rename the item as specified in the enforced-import-renames config option. Note: Even though this lint is warn-by-default, it will only trigger if import renames are defined in the clippy.toml file
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?