clippy::mem_replace_option_with_some: replacing an `Option` with `Some(..)`

What you see

warning: replacing an `Option` with `Some(..)`
 --> main.rs:4:16
  |
4 | let replaced = std::mem::replace(&mut an_option, Some(1));
  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `Option::replace()` instead: `an_option.replace(1)`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#mem_replace_option_with_some
  = note: `#[warn(clippy::mem_replace_option_with_some)]` on by default

Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.

Does it matter?

Option already has the method replace() for taking its current value (Some(…) or None) and replacing it with Some(…).

Code that works but is not idiomatic Rust. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

let mut an_option = Some(0);
let replaced = std::mem::replace(&mut an_option, Some(1));

Write this instead

let mut an_option = Some(0);
let taken = an_option.replace(1);

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

#[allow(clippy::mem_replace_option_with_some)]
fn my_function() { /* ... */ }

[lints.clippy]
mem_replace_option_with_some = "allow"

cargo clippy -- -A clippy::mem-replace-option-with-some

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Settings in clippy.toml

• msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml