Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::mem_replace_with_default: replacing a value of type `T` with `T::default()`
What it meansChecks for std::mem::replace on a value of type T with T::default(). It is in the style group and warns by default.
What you see
warning: replacing a value of type `T` with `T::default()` --> main.rs:4:16 | 4 | let replaced = std::mem::replace(&mut text, String::default()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `std::mem::take` instead: `std::mem::take(&mut text)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#mem_replace_with_default = note: `#[warn(clippy::mem_replace_with_default)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
std::mem module already has the method take to take the current value and replace it with the default value of that type.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let mut text = String::from("foo");
let replaced = std::mem::replace(&mut text, String::default());
Write this instead
let mut text = String::from("foo");
let taken = std::mem::take(&mut text);
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::mem_replace_with_default)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
mem_replace_with_default = "allow"One run
cargo clippy -- -A clippy::mem-replace-with-defaultThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks for std::mem::replace on a value of type
T with T::default().
Why is this bad?
std::mem module already has the method take to
take the current value and replace it with the default value of that type.
Example
let mut text = String::from("foo");
let replaced = std::mem::replace(&mut text, String::default());
Is better expressed with:
let mut text = String::from("foo");
let taken = std::mem::take(&mut text);
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- match_result_okChecks for unnecessary ok() in while let
- mem_replace_option_with_nonereplacing an `Option` with `None`
- mem_replace_option_with_somereplacing an `Option` with `Some(..)`
- missing_enforced_import_renamesChecks for imports that do not rename the item as specified in the enforced-import-renames config option. Note: Even though this lint is warn-by-default, it will only trigger if import renames are defined in the clippy.toml file
- missing_safety_docChecks for the doc comments of publicly visible unsafe functions and warns if there is no # Safety section
- mixed_attributes_styleChecks for items that have the same kind of attributes with mixed styles (inner/outer)
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?