Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::needless_late_init: unneeded late initialization
What it meansChecks for late initializations that can be replaced by a let statement with an initializer. It is in the style group and warns by default.
What you see
warning: unneeded late initialization --> main.rs:3:1 | 3 | let a; | ^^^^^^ created here 4 | a = 1; | ^^^^^ initialised here | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#needless_late_init = note: `#[warn(clippy::needless_late_init)]` on by default help: move the declaration `a` here | 3 + 4 ~ let a = 1; |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Assigning in the let statement is less repetitive.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let a;
a = 1;
let b;
match 3 {
0 => b = "zero",
1 => b = "one",
_ => b = "many",
}
let c;
if true {
c = 1;
} else {
c = -1;
}
Write this instead
let a = 1;
let b = match 3 {
0 => "zero",
1 => "one",
_ => "many",
};
let c = if true {
1
} else {
-1
};
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::needless_late_init)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
needless_late_init = "allow"One run
cargo clippy -- -A clippy::needless-late-initThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for late initializations that can be replaced by a let statement
with an initializer.
Why is this bad?
Assigning in the let statement is less repetitive.
Example
let a;
a = 1;
let b;
match 3 {
0 => b = "zero",
1 => b = "one",
_ => b = "many",
}
let c;
if true {
c = 1;
} else {
c = -1;
}
Use instead:
let a = 1;
let b = match 3 {
0 => "zero",
1 => "one",
_ => "many",
};
let c = if true {
1
} else {
-1
};
Configuration
check-grouped-late-init: Whether to check for grouped late initializations from multipleletstatements.
Example
let a;
let b;
if true {
a = 1;
b = 2;
} else {
a = 3;
b = 4;
}
Use instead:
let (a, b) = if true {
(1, 2)
} else {
(3, 4)
};
(default: true)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- needless_borrows_for_generic_argsthe borrowed expression implements the required traits
- needless_doctest_mainChecks for fn main() {
- needless_elsethis `else` branch is empty
- needless_parens_on_range_literalsneedless parenthesis on range literals can be removed
- needless_pub_selfunnecessary `pub(self)`
- needless_range_loopthe loop variable `i` is only used to index `vec`
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?