Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::needless_range_loop: the loop variable `i` is only used to index `vec`
What it meansChecks for looping over the range of 0..len of some collection just to get the values by index. It is in the style group and warns by default.
What you see
warning: the loop variable `i` is only used to index `vec` --> main.rs:4:10 | 4 | for i in 0..vec.len() { | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 4 - for i in 0..vec.len() { 4 + for <item> in &vec { |
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Just iterating the collection itself makes the intent more clear and is probably faster because it eliminates the bounds check that is done when indexing.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy does not fix this one automatically (its suggestion may change behaviour, so it only shows it). Change the code by hand:
Flagged
let vec = vec!['a', 'b', 'c'];
for i in 0..vec.len() {
println!("{}", vec[i]);
}
Write this instead
let vec = vec!['a', 'b', 'c'];
for i in vec {
println!("{}", i);
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::needless_range_loop)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
needless_range_loop = "allow"One run
cargo clippy -- -A clippy::needless-range-loopThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for looping over the range of 0..len of some
collection just to get the values by index.
Why is this bad?
Just iterating the collection itself makes the intent more clear and is probably faster because it eliminates the bounds check that is done when indexing.
Example
let vec = vec!['a', 'b', 'c'];
for i in 0..vec.len() {
println!("{}", vec[i]);
}
Use instead:
let vec = vec!['a', 'b', 'c'];
for i in vec {
println!("{}", i);
}
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- needless_late_initunneeded late initialization
- needless_parens_on_range_literalsneedless parenthesis on range literals can be removed
- needless_pub_selfunnecessary `pub(self)`
- needless_return_with_question_markChecks for return statements on Err paired with the ? operator
- neg_multiplyChecks for multiplication by -1 as a form of negation
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?