Clippy lints / Style
Clippy lint · Style · checked with Clippy 0.1.99
clippy::needless_pub_self: unnecessary `pub(self)`
What it meansChecks for usage of pub(self) and pub(in self). It is in the style group and warns by default.
What you see
warning: unnecessary `pub(self)` --> main.rs:3:1 | 3 | pub(self) type OptBox<T> = Option<Box<T>>; | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#needless_pub_self = note: `#[warn(clippy::needless_pub_self)]` on by default = help: remove it
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
It’s unnecessary, omitting the pub entirely will give the same results.
Code that works but is not idiomatic Rust. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
pub(self) type OptBox<T> = Option<Box<T>>;
Write this instead
type OptBox<T> = Option<Box<T>>;
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::needless_pub_self)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
needless_pub_self = "allow"One run
cargo clippy -- -A clippy::needless-pub-selfThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of pub(self) and pub(in self).
Why is this bad?
It’s unnecessary, omitting the pub entirely will give the same results.
Example
pub(self) type OptBox<T> = Option<Box<T>>;
Use instead:
type OptBox<T> = Option<Box<T>>;
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- needless_returnunneeded `return` statement
- new_without_defaultChecks for public types with a pub fn new() -> Self method and no implementation of Default
- len_zeroChecks for getting the length of something via .len() just to compare to zero, and suggests using .is_empty() where applicable
- needless_elsethis `else` branch is empty
- needless_late_initunneeded late initialization
- needless_parens_on_range_literalsneedless parenthesis on range literals can be removed
- needless_range_loopthe loop variable `i` is only used to index `vec`
- needless_return_with_question_markChecks for return statements on Err paired with the ? operator
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::needless_returnunneeded `return` statementRead it next →Did this answer your question?