Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::redundant_as_str: Checks for usage of as_str() on a String chained with a method available on the String itself
What it meansChecks for usage of as_str() on a String chained with a method available on the String itself. It is in the complexity group and warns by default.
Does it matter?
The as_str() conversion is pointless and can be removed for simplicity and cleanliness.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let owned_string = "This is a string".to_owned();
owned_string.as_str().as_bytes()
Write this instead
let owned_string = "This is a string".to_owned();
owned_string.as_bytes()
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::redundant_as_str)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
redundant_as_str = "allow"One run
cargo clippy -- -A clippy::redundant-as-strThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of as_str() on a String chained with a method available on the String itself.
Why is this bad?
The as_str() conversion is pointless and can be removed for simplicity and cleanliness.
Example
let owned_string = "This is a string".to_owned();
owned_string.as_str().as_bytes()
Use instead:
let owned_string = "This is a string".to_owned();
owned_string.as_bytes()
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- precedenceChecks for operations where precedence may be unclear and suggests to add parentheses. It catches a mixed usage of arithmetic and bit shifting/combining operators, as well as method calls applied to closures
- ptr_offset_with_castuse of `offset` with a `usize` cast to an `isize`
- range_zip_with_lenChecks for zipping a collection with the range of 0.._.len()
- redundant_async_blockthis async expression only awaits a single future
- redundant_at_rest_patternusing a rest pattern to bind an entire slice to a local
- redundant_closure_calltry not to call a closure in the expression where it is declared
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?