Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::redundant_closure_call: try not to call a closure in the expression where it is declared
What it meansDetects closures called in the same expression where they are defined. It is in the complexity group and warns by default.
What you see
warning: try not to call a closure in the expression where it is declared --> main.rs:3:9 | 3 | let a = (|| 42)(); | ^^^^^^^^^ help: try doing something like: `42` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#redundant_closure_call = note: `#[warn(clippy::redundant_closure_call)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
It is unnecessarily adding to the expression’s complexity.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let a = (|| 42)();
Write this instead
let a = 42;
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::redundant_closure_call)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
redundant_closure_call = "allow"One run
cargo clippy -- -A clippy::redundant-closure-callThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Detects closures called in the same expression where they are defined.
Why is this bad?
It is unnecessarily adding to the expression’s complexity.
Example
let a = (|| 42)();
Use instead:
let a = 42;
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- redundant_as_strChecks for usage of as_str() on a String chained with a method available on the String itself
- redundant_async_blockthis async expression only awaits a single future
- redundant_at_rest_patternusing a rest pattern to bind an entire slice to a local
- redundant_guardsChecks for unnecessary guards in match expressions
- redundant_slicingredundant slicing of the whole range
- repeat_oncecalling `repeat(1)` on a string literal
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?