Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::redundant_at_rest_pattern: using a rest pattern to bind an entire slice to a local
What it meansChecks for [all @ ..] patterns. It is in the complexity group and warns by default.
What you see
warning: using a rest pattern to bind an entire slice to a local --> main.rs:3:8 | 3 | if let [all @ ..] = &*v { | ^^^^^^^^^^ help: this is better represented with just the binding: `all` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#redundant_at_rest_pattern = note: `#[warn(clippy::redundant_at_rest_pattern)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
In all cases, all works fine and can often make code simpler, as you possibly won’t need to convert from say a Vec to a slice by dereferencing.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
if let [all @ ..] = &*v {
// NOTE: Type is a slice here
println!("all elements: {all:#?}");
}
Write this instead
if let all = v {
// NOTE: Type is a `Vec` here
println!("all elements: {all:#?}");
}
// or
println!("all elements: {v:#?}");
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::redundant_at_rest_pattern)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
redundant_at_rest_pattern = "allow"One run
cargo clippy -- -A clippy::redundant-at-rest-patternThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for [all @ ..] patterns.
Why is this bad?
In all cases, all works fine and can often make code simpler, as you possibly won’t need
to convert from say a Vec to a slice by dereferencing.
Example
if let [all @ ..] = &*v {
// NOTE: Type is a slice here
println!("all elements: {all:#?}");
}
Use instead:
if let all = v {
// NOTE: Type is a `Vec` here
println!("all elements: {all:#?}");
}
// or
println!("all elements: {v:#?}");
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- range_zip_with_lenChecks for zipping a collection with the range of 0.._.len()
- redundant_as_strChecks for usage of as_str() on a String chained with a method available on the String itself
- redundant_async_blockthis async expression only awaits a single future
- redundant_closure_calltry not to call a closure in the expression where it is declared
- redundant_guardsChecks for unnecessary guards in match expressions
- redundant_slicingredundant slicing of the whole range
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?