Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::result_map_unit_fn: Checks for usage of result.map(f) where f is a function or closure that returns the unit type ()
What it meansChecks for usage of result.map(f) where f is a function or closure that returns the unit type (). It is in the complexity group and warns by default.
Does it matter?
Readability, this can be written more clearly with an if let statement
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
let x: Result<String, String> = do_stuff();
x.map(log_err_msg);
x.map(|msg| log_err_msg(format_msg(msg)));
Write this instead
let x: Result<String, String> = do_stuff();
if let Ok(msg) = x {
log_err_msg(msg);
};
if let Ok(msg) = x {
log_err_msg(format_msg(msg));
};
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::result_map_unit_fn)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
result_map_unit_fn = "allow"One run
cargo clippy -- -A clippy::result-map-unit-fnThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Clippy's own documentation
What it does
Checks for usage of result.map(f) where f is a function
or closure that returns the unit type ().
Why is this bad?
Readability, this can be written more clearly with an if let statement
Example
let x: Result<String, String> = do_stuff();
x.map(log_err_msg);
x.map(|msg| log_err_msg(format_msg(msg)));
The correct use would be:
let x: Result<String, String> = do_stuff();
if let Ok(msg) = x {
log_err_msg(msg);
};
if let Ok(msg) = x {
log_err_msg(format_msg(msg));
};
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- repeat_oncecalling `repeat(1)` on a string literal
- reserve_after_initializationcall to `reserve` immediately after creation
- result_filter_map`filter` for `Ok` followed by `unwrap`
- seek_from_currentusing `SeekFrom::Current` to start from current position
- seek_to_start_instead_of_rewindChecks for jumps to the start of a stream that implements Seek and uses the seek method providing Start as parameter
- short_circuit_statementChecks for the use of short circuit boolean conditions as a statement
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?