Email me

Clippy lints / Complexity

Clippy lint · Complexity · checked with Clippy 0.1.99

clippy::result_map_unit_fn: Checks for usage of result.map(f) where f is a function or closure that returns the unit type ()

What it meansChecks for usage of result.map(f) where f is a function or closure that returns the unit type (). It is in the complexity group and warns by default.

Does it matter?

Readability, this can be written more clearly with an if let statement

Code that does something simple in a complicated way. Warns by default.

How to fix it

Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.

Flagged

let x: Result<String, String> = do_stuff();
x.map(log_err_msg);
x.map(|msg| log_err_msg(format_msg(msg)));

Write this instead

let x: Result<String, String> = do_stuff();
if let Ok(msg) = x {
    log_err_msg(msg);
};
if let Ok(msg) = x {
    log_err_msg(format_msg(msg));
};

Turn it off, or on

Allow it where it does not fit your code, as narrowly as you can:

On one item

#[allow(clippy::result_map_unit_fn)]
fn my_function() { /* ... */ }

Whole crate (Cargo.toml)

[lints.clippy]
result_map_unit_fn = "allow"

One run

cargo clippy -- -A clippy::result-map-unit-fn

The [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.

Complexitygroup
warndefault level
yesfixed by cargo clippy --fix
pre 1.29.0added in Rust

Clippy's own documentation

What it does

Checks for usage of result.map(f) where f is a function or closure that returns the unit type ().

Why is this bad?

Readability, this can be written more clearly with an if let statement

Example

let x: Result<String, String> = do_stuff();
x.map(log_err_msg);
x.map(|msg| log_err_msg(format_msg(msg)));

The correct use would be:

let x: Result<String, String> = do_stuff();
if let Ok(msg) = x {
    log_err_msg(msg);
};
if let Ok(msg) = x {
    log_err_msg(format_msg(msg));
};

From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.

Related lints

All 847 Clippy lints · Rust compiler errors · Cargo.toml checker

Up next

Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →

Did this answer your question?

Get the receipts by email.

What my AI agents tried this week, with the real numbers: what worked, what flopped, what made money. One email when there is something worth reading.

No spam, never sold. Every email has a one-click unsubscribe.

Popular in the shop

All 124 tools →

Browse: Bundles and kitsHome, family and schoolMoney and businessAI toolsSports and fitnessMaking and hobbiesFood and drinkIndie dev and launchTrading and quant

Free: Landing page teardown iPhone app cost calculator LLM API cost calculator Paid online: $49 Launch Check App builds Articles FAQ