Clippy lints / Complexity
Clippy lint · Complexity · checked with Clippy 0.1.99
clippy::seek_from_current: using `SeekFrom::Current` to start from current position
What it meansChecks if the seek method of the Seek trait is called with SeekFrom::Current(0), and if it is, suggests using stream_position instead. It is in the complexity group and warns by default.
What you see
warning: using `SeekFrom::Current` to start from current position --> main.rs:7:35 | 7 | eprintln!("Written {} bytes", f.seek(SeekFrom::Current(0))?); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `f.stream_position()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/stable/index.html#seek_from_current = note: `#[warn(clippy::seek_from_current)]` on by default
Real output of Clippy 0.1.99 (Rust 1.99) on the example below. Names and line numbers in yours will differ.
Does it matter?
Readability. Use dedicated method.
Code that does something simple in a complicated way. Warns by default.
How to fix it
Clippy can fix this one for you: run cargo clippy --fix (add --allow-dirty if you have uncommitted changes). Review the diff before you commit.
Flagged
use std::fs::File;
use std::io::{self, Write, Seek, SeekFrom};
fn main() -> io::Result<()> {
let mut f = File::create("foo.txt")?;
f.write_all(b"Hello")?;
eprintln!("Written {} bytes", f.seek(SeekFrom::Current(0))?);
Ok(())
}
Write this instead
use std::fs::File;
use std::io::{self, Write, Seek, SeekFrom};
fn main() -> io::Result<()> {
let mut f = File::create("foo.txt")?;
f.write_all(b"Hello")?;
eprintln!("Written {} bytes", f.stream_position()?);
Ok(())
}
Turn it off, or on
Allow it where it does not fit your code, as narrowly as you can:
On one item
#[allow(clippy::seek_from_current)]
fn my_function() { /* ... */ }Whole crate (Cargo.toml)
[lints.clippy]
seek_from_current = "allow"One run
cargo clippy -- -A clippy::seek-from-currentThe [lints] table needs Rust 1.74 or newer. In a workspace, put it under [workspace.lints.clippy] and add [lints] workspace = true to each member.
Settings in clippy.toml
msrv: The minimum rust version that the project supports. Defaults to the rust-version field in Cargo.toml
Clippy's own documentation
What it does
Checks if the seek method of the Seek trait is called with SeekFrom::Current(0),
and if it is, suggests using stream_position instead.
Why is this bad?
Readability. Use dedicated method.
Example
use std::fs::File;
use std::io::{self, Write, Seek, SeekFrom};
fn main() -> io::Result<()> {
let mut f = File::create("foo.txt")?;
f.write_all(b"Hello")?;
eprintln!("Written {} bytes", f.seek(SeekFrom::Current(0))?);
Ok(())
}
Use instead:
use std::fs::File;
use std::io::{self, Write, Seek, SeekFrom};
fn main() -> io::Result<()> {
let mut f = File::create("foo.txt")?;
f.write_all(b"Hello")?;
eprintln!("Written {} bytes", f.stream_position()?);
Ok(())
}
Configuration
-
msrv: The minimum rust version that the project supports. Defaults to therust-versionfield inCargo.toml(default:
current version)
From the Clippy lint list (0.1.99), part of the Rust project, MIT or Apache-2.0. Official entry.
Related lints
- too_many_argumentsChecks for functions with too many parameters
- clone_on_copyusing `clone` on type `u64` which implements the `Copy` trait
- type_complexityChecks for types used in structs, parameters and let declarations above a certain complexity threshold
- reserve_after_initializationcall to `reserve` immediately after creation
- result_filter_map`filter` for `Ok` followed by `unwrap`
- result_map_unit_fnChecks for usage of result.map(f) where f is a function or closure that returns the unit type ()
- seek_to_start_instead_of_rewindChecks for jumps to the start of a stream that implements Seek and uses the seek method providing Start as parameter
- short_circuit_statementChecks for the use of short circuit boolean conditions as a statement
- single_element_loopfor loop over a single element
All 847 Clippy lints · Rust compiler errors · Cargo.toml checker
Up next
Related lintclippy::too_many_argumentsChecks for functions with too many parametersRead it next →Did this answer your question?